Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional headers to be passed into the authentication parameters #68

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

jack-kearney
Copy link
Contributor

No description provided.

@jack-kearney jack-kearney marked this pull request as ready for review October 17, 2024 17:50
Copy link
Collaborator

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple notes and nits

client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
Copy link
Collaborator

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you just have some linting problems remaining.

@@ -13,8 +13,8 @@ import (
)

func main() {
// NB: make sure to create and register an API key, first.
client, err := sdk.New("default")
// NB: make sure to create and register an API key,first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental space deletion?

@@ -13,8 +13,8 @@ import (
)

func main() {
// NB: make sure to create and register an API key, first.
client, err := sdk.New("default")
// NB: make sure to create WithAPIKeyand register an API key, first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another accidental space deletion?

Copy link
Collaborator

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple stray comment whitespace deletions, but LGTM

@Ulexus Ulexus merged commit b7a95a5 into main Oct 24, 2024
3 checks passed
@Ulexus Ulexus deleted the jack/append-headers branch October 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants