-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable optional headers to be passed into the authentication parameters #68
Conversation
f387461
to
436dc3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes and nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you just have some linting problems remaining.
@@ -13,8 +13,8 @@ import ( | |||
) | |||
|
|||
func main() { | |||
// NB: make sure to create and register an API key, first. | |||
client, err := sdk.New("default") | |||
// NB: make sure to create and register an API key,first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental space deletion?
@@ -13,8 +13,8 @@ import ( | |||
) | |||
|
|||
func main() { | |||
// NB: make sure to create and register an API key, first. | |||
client, err := sdk.New("default") | |||
// NB: make sure to create WithAPIKeyand register an API key, first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another accidental space deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple stray comment whitespace deletions, but LGTM
36ff3d9
to
cb38ffc
Compare
No description provided.