add buffer polyfill for webauthn-stamper #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
CI: |
r-n-o
reviewed
Oct 4, 2023
| @@ -4480,7 +4484,7 @@ packages: | |||
| /@types/bn.js@5.1.2: | |||
| resolution: {integrity: sha512-dkpZu0szUtn9UXTmw+e0AJFd4D2XAxDnsCLdc05SfqpqzPEBft8eQr8uaFitfo/dUUOZERaLec2hHMG87A4Dxg==} | |||
| dependencies: | |||
| '@types/node': 20.6.2 | |||
| '@types/node': 16.18.12 | |||
There was a problem hiding this comment.
why is that happening? Is this on purpose?
There was a problem hiding this comment.
was just trying to figure this out - after doing some testing, it does not look like local node version (toggled using nvm) is the cause. i think it could be the installation of buffer that introduces this deep dependency change
r-n-o
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Resolves Uncaught ReferenceError: Buffer is not defined in environments where Buffer is not polyfilled (e.g. non-NextJS environments)
How I Tested These Changes
examples/with-ethers-and-passkeys
Client also tried via https://pkg.csb.dev/tkhq/sdk/commit/a96c30fc/@turnkey/webauthn-stamper