Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain submodule update #16

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Toolchain submodule update #16

merged 3 commits into from
Apr 28, 2023

Conversation

r-n-o
Copy link
Collaborator

@r-n-o r-n-o commented Apr 28, 2023

This branch updates the toolchain submodule to make make dist work correctly. I got the following error when running locally from a fresh directory:

$ make dist
rm -rf dist/*
/Library/Developer/CommandLineTools/usr/bin/make toolchain-clean default
chmod -R u+w cache
chmod: cache: No such file or directory
make[1]: *** [toolchain-clean] Error 1
make: *** [dist] Error 2

I verified that the error is gone after the submodule bump. This is because toolchain is now checking for the existence of the cache dir before deleting it: https://codeberg.org/distrust/toolchain/src/commit/4eff8b258b1e9bc64f3d831ae160ac9256bfdd79/Makefile#L90-L93

@r-n-o r-n-o requested a review from lrvick April 28, 2023 19:20
@lrvick lrvick merged commit 348d073 into main Apr 28, 2023
@lrvick lrvick deleted the rno/toolchain-submodule-update branch April 28, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants