Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply key formatting to encrypt command #56

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

oliviathet
Copy link
Contributor

@oliviathet oliviathet commented Mar 13, 2024

Summary & Motivation (Problem vs. Solution)

Add --key-format flag for encrypt command that accepts mnemonic (default), hexadecimal, and solana.

turnkey encrypt \
--import-bundle-input "./import_bundle.txt" \
--encrypted-bundle-output "./encrypted_bundle.txt" \
--plaintext-input /dev/fd/3 3<<<"$SEEDPHRASE_1"
--key-format "mnemonic"

Tested the following scenarios:

  • encrypt mnemonic with no --key-format flag then import wallet ✅
  • encrypt mnemonic with --key-format mnemonic flag then import wallet ✅
  • encrypt hex-encoded hex key with --key-format hexadecimal flag then import key w ethereum address format and secp256k1 curve ✅
  • encrypt phantom solana key with --key-format solana flag then import key w solana address format and ed25519 curve ✅

Release Steps

See README for additional details.

  • Tag the release (once approved)
  • Attest (once merged)
  • Create release with changelog
  • Update Homebrew tap

@oliviathet oliviathet changed the title (WIP) Apply key formatting to encrypt command Apply key formatting to encrypt command Mar 13, 2024
@oliviathet oliviathet merged commit 466bb7a into main Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants