Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin etwmon #1553

Merged
merged 5 commits into from
Nov 25, 2022
Merged

New plugin etwmon #1553

merged 5 commits into from
Nov 25, 2022

Conversation

archercreat
Copy link
Contributor

Abstract

The etwmon plug-in detects various etw-related modifications in windows kernel.

Description

List of things etwmon monitors:

  • Global ETW handles: EtwpPsProvRegHandle, EtwpRegTraceHandle, etc
  • Global ETW Callback pointers: EtwpDiskIoNotifyRoutines, EtwpFileIoNotifyRoutines, etc
  • ETW Loggers: GetCPUClock aka infinity hook technique, CallbackContext
  • ETW Providers: ProviderEnableInfo, etc

Checks are made at the end of analysis and don't affect vm performance.

return false;
}

etwmon::etwmon(drakvuf_t drakvuf, output_format_t output)

Check warning

Code scanning / CodeQL

Poorly documented large function

Poorly documented function: fewer than 2% comments for a function of 124 lines.
Comment on lines +317 to +321
// struct _ETW_HASH_BUCKET
// {
// struct _LIST_ENTRY ListHead[3];
// struct _EX_PUSH_LOCK BucketLock;
// };

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
@tklengyel
Copy link
Owner

@drakvuf-jenkins This is OK to test

@drakvuf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@tklengyel
Copy link
Owner

@drakvuf-jenkins Retest this please

@tklengyel tklengyel merged commit ce870ce into tklengyel:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants