Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate client Add UM Users feature with the backend enrollment endpoint #208

Closed
ssciolla opened this issue Sep 29, 2021 · 0 comments · Fixed by #214
Closed

Integrate client Add UM Users feature with the backend enrollment endpoint #208

ssciolla opened this issue Sep 29, 2021 · 0 comments · Fixed by #214
Assignees
@ssciolla
Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files

Comments

@ssciolla
Copy link
Contributor

With #165 and #177 merged, we can now connect the client code with the api/sections/:id/enroll endpoint. This will involve changes to api.ts and the AddUMUsers.tsx page, among other files.
@ssciolla ssciolla added enhancement New feature or request front end Involves changes to the React application or other client-related files labels Sep 29, 2021
@ssciolla ssciolla self-assigned this Sep 29, 2021
@ssciolla ssciolla linked a pull request Oct 5, 2021 that will close this issue
Connect Add UM Users to backend, extract some common components from pages (#197, #206, #208) #214
Merged
@ssciolla ssciolla mentioned this issue Oct 5, 2021
Merged
ssciolla added a commit that referenced this issue Oct 8, 2021
@ssciolla
Connect Add UM Users to backend, extract some common components from …
b70ba29 
…pages (#197, #206, #208) (#214)

* Add WIP for client-server integration for Add UM Users; extract SuccessCard

* Refactor DefaultError as CanvasError; fix typing

* Extract generic error component APIErrorAlert; use in AddUMUsers.tsx and BulkSectionCreate.tsx

* Generalize ConfirmationTable as CustomTable

* Create CanvasAPIErrorsTable; create RowLevelErrorsContent; enable error clearing in usePromise; implement better error handling in AddUMUsers

* Allow for custom message in RowLevelErrorsContent

* Implement CSVFileName; use in AddUMUsers; add one more usage of RowLevelErrorsContent

* Add some additional handling of 404 errors for bulk processes

* Use extracted components in BulkSectionsCreate; rename some API hook variables

* Add missing period and newline to models/canvas.ts

* Use extracted components in GradebookCanvas page

* Make failedInput for enrollments more human-readable

* Make APIErrorPayload typing a bit stricter

* Tweak handling of enrollments data before API call

* Move CSVFileNameProps interface

* Make minor tweaks to SuccessCard

* Make handleErrors DRYer; handle theoretical rate-limiting/forbidden Canvas errors

* Make some syntactical changes to AddUMUsers; add button spacing; change general API failure button action

* Capitalize hex value in RowLevelErrorsContent; extend Record instead of using index signature in APIErrorData

* Remove comment about CanvasEnrollment.type

* Rework Canvas role typing to make extra error throwing unnecessary

* Fix sorting issues with numbers in strings

* Tweak "Or select ..." language

* Fix get sections gap when using "Try Again" button

* APIErrorAlert => ErrorAlert; handle file-level error; refactor some resetting; throw validation error on empty loginId; tweak requirements text

* Correct props name for ErrorAlert

* Fix language re: 400 user limit as requested
@pushyamig pushyamig reopened this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssciolla ssciolla

Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files
Projects
None yet
Milestone
No milestone
2 participants
@pushyamig @ssciolla