-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema caching needs xmlschema version #19
Comments
|
Remember there are only 2 truly hard problems in computer science: Naming things, cache invalidation, and off-by-one errors. |
that's hilarious. |
sounds good. I'll add the xsd to source. I think i'll leave the caching in there for now, but include the xmlschema version string and ome-types version in the key. That should cover everything but development woes, and we can deal with that ourselves |
Actually the schema parse only takes 1 second. I was accidentally timing it loading from the URL rather than a local file. I don't know if 1 second is even worth all the hassles of caching. (e.g. if it's a zipped wheel install, that path doesn't even exist for writing a file to and you need to find somewhere else...) |
just so I don't forget to fix it: when testing #17 locally a few tests failed that weren't testing on CI, so I updated xmlschema to check... and they all failed. I realized that it was ultimately due to the pickled schema cache being stale. So that cache key should minimally have the xmlschema version in it, but maybe we don't cache at all.
The text was updated successfully, but these errors were encountered: