Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make light sources and shapes work #17

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

jmuhlich
Copy link
Collaborator

@jmuhlich jmuhlich commented Jul 22, 2020

This gets seven more example files to pass. Annotations are next on my list. In the process of stretching the override system even further with a new slot I decided to refactor the entries into instances of a small new dataclass for better readability.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   95.20%   95.46%   +0.26%     
==========================================
  Files           1        1              
  Lines         396      419      +23     
==========================================
+ Hits          377      400      +23     
  Misses         19       19              
Impacted Files Coverage Δ
src/ome_autogen.py 95.46% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9966e...90c5700. Read the comment docs.

Copy link
Owner

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more awesomeness. thanks! totally fine with the hacks and extensions to overrides for now. will be much easier to refactor once we see how it needs to look in order to work.

is this all set to go?

@jmuhlich
Copy link
Collaborator Author

Yes, ship it! :shipit:

@tlambert03 tlambert03 merged commit 4012024 into tlambert03:master Jul 22, 2020
@jmuhlich jmuhlich deleted the lightsources-shapes branch July 22, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants