fix datetime writing #106
Merged
fix datetime writing #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! I don't think preserving the 7 sub-second digits is important for our users, so this seems totally fine to me. I'll give the patched version a try in our code shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104
@MatteBailey, this should do it. this PR also includes #105 which also unpins xmlschema (whose updates had been causing some problems)
the one thing I was unable to do, unfortunately, is preserve the 7 "sub-second" digits. this is a limitation of python's datetime object which only support 6 digits of sub-second precision, so your date will go from
...9251548Zto...925154Zwhen writing out.