Improve model for BinData #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the schema BinData is an extension of string, but modeling this in python as a subclass of str with extra constructor args is not feasible. Instead this change moves the string content to a `value` attribute which aligns with how our to_dict converter presents element text content. Fixes tlambert03#9
* Now that BinData parses properly we can remove the xfail marker from about half of the sample ome-xml files * Refactor filename stem extraction * Invert SHOULD_PASS to SHOULD_FAIL for easier updating * Remove +x mode bit from sample xml files
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 95.40% 95.20% -0.21%
==========================================
Files 1 1
Lines 392 396 +4
==========================================
+ Hits 374 377 +3
- Misses 18 19 +1
Continue to review full report at Codecov.
|
tlambert03
approved these changes
Jul 21, 2020
| @@ -35,16 +54,19 @@ def mark_xfail(fname): | |||
| ), | |||
| ) | |||
|
|
|||
| def true_stem(p): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.