Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default parser, add FutureWarning for v0.4.0 change #138

Merged
merged 1 commit into from
May 25, 2022

Conversation

tlambert03
Copy link
Owner

I'd like to release a new version with the awesome lxml parser added by @Nicholas-Schaub, but I'm just a bit wary of changing up the default all in one go (since I can't be certain that there aren't some consequences for untested applications).

This PR sets the default parser to None. If parser is None, it shows a FutureWarning, explaining that the behavior will change in v0.4.0, and then defaults back to the xmlschema parser. To silence the warning you can either opt in to the new behavior with parser='lxml', or retain the old behavior with parser='xmlschema'

@jmuhlich @Nicholas-Schaub, lemme know if this is ok with you guys. If so, I'll merge and release 0.3.0, then will release 0.4.0 with the new default (and no more warning in a month or two)

@Nicholas-Schaub
Copy link
Contributor

Works for me.

@tlambert03
Copy link
Owner Author

Since we discussed it in person, I'm going to optimistically assume that @jmuhlich is on board with this and merge/release 😂

@tlambert03 tlambert03 merged commit fbbf567 into main May 25, 2022
@tlambert03 tlambert03 deleted the change-default branch May 25, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants