Revert default parser, add FutureWarning for v0.4.0 change #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to release a new version with the awesome lxml parser added by @Nicholas-Schaub, but I'm just a bit wary of changing up the default all in one go (since I can't be certain that there aren't some consequences for untested applications).
This PR sets the default parser to
None
. Ifparser
isNone
, it shows aFutureWarning
, explaining that the behavior will change in v0.4.0, and then defaults back to thexmlschema
parser. To silence the warning you can either opt in to the new behavior withparser='lxml'
, or retain the old behavior withparser='xmlschema'
@jmuhlich @Nicholas-Schaub, lemme know if this is ok with you guys. If so, I'll merge and release 0.3.0, then will release 0.4.0 with the new default (and no more warning in a month or two)