Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move deprecated init kwargs to proper fields #194

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Jul 8, 2023

moves deprecated field names in init:

    # UserWarning: Field 'm' is deprecated. Use 'ms' instead.
    mapann = model.MapAnnotation(
        id="Annotation:3",
        value=model.Map(m=[{"k": "key", "value": "value"}]), 
    )

    assert len(mapann.value.ms) == 1

@tlambert03 tlambert03 changed the title fix: fix init args fix: Move deprecated init kwargs to proper fields Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #194 (f56fed3) into main (a329034) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   31.07%   30.85%   -0.23%     
==========================================
  Files          25       25              
  Lines         840      846       +6     
==========================================
  Hits          261      261              
- Misses        579      585       +6     
Impacted Files Coverage Δ
src/ome_types/_mixins/_base_type.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit d718228 into main Jul 8, 2023
@tlambert03 tlambert03 deleted the fix-init branch July 8, 2023 15:07
@tlambert03 tlambert03 added the bug Something isn't working label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant