feat: add transformations to from_xml #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses, and I'm going to say closes #129
It adds a new
transformations
argument tofrom_xml
which lets the user add any number of "fixers" before converting xml. There is a new module
ome_types.etree_fixes
with some standard fixes, and PRs can be opened to add more. So, to use them all:HOWEVER:
With v0.4.0, many of the fixes that are included in the aicsimageio
clean_ome_xml_for_known_issues
function referenced in #129 (i.e., ID and references fixes, namespace capitalization, ordering of elements) are no longer necessary as they are handled fine by default. Some will emit warnings, and thetransformations
could be used to avoid those warnings. But in general, I think this is a flexible enough approach that anyone can extend if needed