Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: show logs for each test file #68

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

johnyf
Copy link
Contributor

@johnyf johnyf commented Jun 20, 2022

  • BUG: correct quoting of environment-variable values in the script setup_shell_env.py, to avoid errors in CI workflow of release.yml.

  • run workflow of file .github/workflows/release.yml whenever the file changes, and also twice a year.

  • add underscores and "UTC" to tag name created by GitHub Actions when running release.yml.

@johnyf johnyf force-pushed the release_installer_on_github branch from 84f6874 to 0bbd7e3 Compare June 28, 2022 20:16
@ahelwer
Copy link
Collaborator

ahelwer commented Jun 21, 2024

@johnyf could you rebase these on the current CI files to see whether these changes should be merged?

@johnyf johnyf force-pushed the release_installer_on_github branch from 0bbd7e3 to 397a092 Compare June 23, 2024 14:35
@johnyf
Copy link
Contributor Author

johnyf commented Jun 23, 2024

Rebased the changes onto branch main. The changes are:

  • release tag name of the form YEAR_MM_DD_UTC_HH_MM
  • running release.yml when it changes, and twice a year
  • showing contents of *.err and *.out files when tests fail, in ci.yml.

@ahelwer
Copy link
Collaborator

ahelwer commented Jun 23, 2024

Thanks for doing the rebase!

  1. Was the original fix for quoting environment variables no longer necessary?
  2. I like the practice of dumping test output files to console so we get the output in the CI!
  3. I am not sure about the updated release practice; may have to defer to someone else in their thoughts here.

P.S. there's a requirement to sign your commits with a DCO (basically just saying you personally wrote this code and can legally contribute it and it isn't copied from a proprietary codebase or whatever), the github CI failure should have a link telling you how to retroactively add a DCO signoff to your commits.

@johnyf johnyf force-pushed the release_installer_on_github branch from 397a092 to c26e347 Compare June 24, 2024 06:19
@johnyf
Copy link
Contributor Author

johnyf commented Jun 24, 2024

Yes, the original fix for quoting environment variables was to code that is not in the current main branch.
The automated building with cron could be omitted.
Added the DCO signoff to the commits. Thank you for reviewing the changes.

@ahelwer
Copy link
Collaborator

ahelwer commented Jun 24, 2024

In #92 there was discussion of moving to a rolling release model (which I have really been dragging my feet on getting around to doing). So I think people want to keep the current release model then transition to that one, instead of releasing every six months + whenever release.yml is modified. However, I like all the other changes!

@ahelwer
Copy link
Collaborator

ahelwer commented Jun 24, 2024

Also @damiendoligez as FYI, I believe this is the issue you mentioned in the last community meeting

@ahelwer
Copy link
Collaborator

ahelwer commented Dec 4, 2024

@johnyf we implemented rolling releases in #182 so there is no need for the changes to the release CI file. However, I think dumping the test output files is still a good idea; if you'd like to remove the changes to release.yml I will merge this. Also I think the PR title might need to be changed, I don't think there is anything to do with environment variable quoting in the changes anymore.

upon failure of any tests.

Signed-off-by: Ioannis Filippidis <jfilippidis@gmail.com>
@johnyf johnyf force-pushed the release_installer_on_github branch from c26e347 to 4215d85 Compare December 5, 2024 13:42
@johnyf johnyf changed the title BUG: quoting of environment variables for CI, and automatically run release.yml CI: show logs for each test file Dec 5, 2024
@johnyf
Copy link
Contributor Author

johnyf commented Dec 5, 2024

Rebased to revise the changes and updated the title of the pull request.

@ahelwer ahelwer merged commit b09b8e9 into tlaplus:main Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants