This repository has been archived by the owner on May 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuchenJin
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, the relax task extraction code is so simple now. Thanks Masa for the first relax pr! 🔥
cc @sunggg it would be good if you can take a look |
LGTM, thanks you for the clean up, Masa! |
Thanks @masahi for the work!!! thanks for the review. @YuchenJin @sunggg |
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Mar 14, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Mar 22, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Mar 23, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Apr 6, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Apr 12, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
that referenced
this pull request
May 10, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
that referenced
this pull request
May 11, 2022
* Clean up taske extraction * black
YuchenJin
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Clean up taske extraction * black
jinhongyii
pushed a commit
to jinhongyii/relax
that referenced
this pull request
Jun 5, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Jun 12, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
to yongwww/relax
that referenced
this pull request
Jul 15, 2022
* Clean up taske extraction * black
yongwww
pushed a commit
that referenced
this pull request
Aug 14, 2022
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Clean up taske extraction * black
YuchenJin
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Clean up taske extraction * black
tqchen
pushed a commit
to tqchen/relax
that referenced
this pull request
Jan 9, 2023
vinx13
pushed a commit
to vinx13/relax
that referenced
this pull request
Jan 9, 2023
YuchenJin
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Clean up taske extraction * black
YuchenJin
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
to junrushao/relax
that referenced
this pull request
Jan 25, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
to junrushao/relax
that referenced
this pull request
Jan 26, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
to junrushao/relax
that referenced
this pull request
Jan 29, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
to junrushao/relax
that referenced
this pull request
Feb 5, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
to junrushao/relax
that referenced
this pull request
Feb 6, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Clean up taske extraction * black
junrushao
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Clean up taske extraction * black
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current task extraction code was apparently copy-pasted from the Relay one and it has many unnecessary bits. Moreover, it will break after apache/tvm#10578 in
main
.