Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta Schedule][BugFix] Fix PostProc RewriteReductionBlock #487

Conversation

MasterJH5574
Copy link
Collaborator

This PR fixes a bug in the post-processor RewriteReductionBlock.

Due to my carelessness when implementing the search rule for cross-thread reduction, I mistakenly forgot to return false in the method bool AllReductionIterVarAreUnbound(...). This caused the post-processor never working... Because the method never returns true - the post-processor never extracts the inits from reduction blocks. So sorry for this bug 🙏.

Thanks @spectrometerHBH for reporting this bug ❤️.

@junrushao1994 @zxybazh Now I have two concerns:

  1. does the fix conflict the meta-schedule refactor that you guys are doing? If you've already finished the post-processor refactor (which I guess is in [Meta Schedule][M3c] Schedule Rules, Mutator & Postprocs #485), I may need your help to update this fix to the refactored version.
  2. I do want to write some unit tests to make sure that the post-processor indeed works before merging this PR. Do you have any suggestions on how to implement such a test?

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

  1. It’s not conflicted. Don’t worry about it :-)
  2. Let’s do that during upstreaming

@zxybazh
Copy link
Collaborator

zxybazh commented Oct 18, 2021

From my point of view, it does not conflict with the current implementation so no worries : )

@MasterJH5574
Copy link
Collaborator Author

Thanks! That's awesome. So let's get it merged first and add tests further during upstream :-)

@MasterJH5574 MasterJH5574 merged commit 330c35b into tlc-pack:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants