[Meta Schedule][BugFix] Fix PostProc RewriteReductionBlock
#487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the post-processor
RewriteReductionBlock
.Due to my carelessness when implementing the search rule for cross-thread reduction, I mistakenly forgot to return false in the method
bool AllReductionIterVarAreUnbound(...)
. This caused the post-processor never working... Because the method never returnstrue
- the post-processor never extracts theinit
s from reduction blocks. So sorry for this bug 🙏.Thanks @spectrometerHBH for reporting this bug ❤️.
@junrushao1994 @zxybazh Now I have two concerns: