fix set label to translation pages #2
Conversation
src/labeler.spec.ts
Outdated
| @@ -0,0 +1,130 @@ | |||
| const {getFileLabel, fileStatus, labelType} = require('./labeler') | |||
There was a problem hiding this comment.
Both tldr-node-client and tldr-lint have their tests in their own directory. I would suggest doing the same here.
There was a problem hiding this comment.
If I create a folder outside `src, I get this error:
$ ncc build src/index.ts --out dist
ncc: Version 0.32.0
ncc: Compiling file index.js into CJS
ncc: Using typescript@4.5.2 (local user-provided)
Error: [tsl] ERROR
TS6059: File '/home/user/src/tldr-labeler-action/test/labeler.spec.ts' is not under 'rootDir' '/home/user/src/tldr-labeler-action/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Root file specified for compilation
at /home/user/src/tldr-labeler-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1896789
at /home/user/src/tldr-labeler-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:353322
at _done (eval at create (/home/user/src/tldr-labeler-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:117937), :7:1)
at eval (eval at create (/home/user/src/tldr-labeler-action/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:117937), :32:22)
There was a problem hiding this comment.
You will probably need to explicitly say what files to include in the tsconfig.json file. This error also demonstrates why we want this file outside of the ncc build, in that we do not want to risk bundling our test sources with our source code for distribution.
There was a problem hiding this comment.
The test file is not included in the bundle.
Co-authored-by: Matthew Peveler <matt.peveler@gmail.com>
| @@ -0,0 +1 @@ | |||
| 12.22 | |||
There was a problem hiding this comment.
Are you sure we can't use anything more modern here? The latest LTS version is 16.x.....
There was a problem hiding this comment.
Nope, the actions run in node12 only.
There was a problem hiding this comment.
Though this only applies for local environments, and does not change anything about the action environment itself, which is controlled in the action.yml file.
However, again, making it so that only people with node12 (or want to switch to it) seems rather heavy handed to ensure node12 compliance...
Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Simplify regex for test directories and files.
Extract testable getFileLabel function.
Simplify loop over changed files.
Use Array instead of Set.
Remove waiting label only.
Add community label for MAINTAINERS.md file.
Add unit tests with jest.
Add husky for run unit tests before push.
Add engine to package.json to know the required runtime easier.