Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translations workflow for GitHub releases #47

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Mar 3, 2024

No description provided.

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun requested a review from SethFalco March 3, 2024 12:46
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a peek at the CONTRIBUTING guide:

https://github.com/tldr-pages/tldr-translation-pairs-gen/blob/main/CONTRIBUTING.md#backward-compatibility

It's cool if we create new assets, but preferably, we shouldn't change how we package the original artifacts.

TL;DR: Makes sense, but can we add the new artifacts instead of replace the existing artifact.

@kbdharun
Copy link
Member Author

kbdharun commented Mar 3, 2024

It's cool if we create new assets, but preferably, we shouldn't change how we package the original artifacts.

Agreed, I will separate this workflow and we can continue to have the existing one that way the GitHub page would be present and we can upload the ZIPs to releases for ease of downloading and redistributing in places like Kaggle.

Edit: Done

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun changed the title feat: switch translations workflow to use GitHub releases feat: add translations workflow for GitHub releases Mar 3, 2024
@kbdharun kbdharun requested a review from SethFalco March 3, 2024 13:35
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fine with this overall, but perhaps the CSV dataset should have CSV in the name similarly to the others for consistency?

That way when someone reviews the releases, users just know it's CSV rather than having to guess what the unspecified format contains.

.github/workflows/translations-release.yml Outdated Show resolved Hide resolved
Co-authored-by: Seth Falco <seth@falco.fun>
@kbdharun kbdharun requested a review from SethFalco March 3, 2024 17:54
@kbdharun kbdharun merged commit 3536d0b into main Mar 3, 2024
3 checks passed
@kbdharun kbdharun deleted the feat/release-assets branch March 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants