-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add translations workflow for GitHub releases #47
Conversation
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a peek at the CONTRIBUTING guide:
It's cool if we create new assets, but preferably, we shouldn't change how we package the original artifacts.
TL;DR: Makes sense, but can we add the new artifacts instead of replace the existing artifact.
Agreed, I will separate this workflow and we can continue to have the existing one that way the GitHub page would be present and we can upload the ZIPs to releases for ease of downloading and redistributing in places like Kaggle. Edit: Done |
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fine with this overall, but perhaps the CSV dataset should have CSV in the name similarly to the others for consistency?
That way when someone reviews the releases, users just know it's CSV rather than having to guess what the unspecified format contains.
Co-authored-by: Seth Falco <seth@falco.fun>
No description provided.