Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkctl: add page and Polish translation #10091

Merged
merged 4 commits into from
Apr 23, 2023
Merged

networkctl: add page and Polish translation #10091

merged 4 commits into from
Apr 23, 2023

Conversation

acuteenvy
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. translation Issues requesting translating pages from English to other languages. labels Apr 19, 2023
kbdharun
kbdharun approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

kbdharun
kbdharun reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor suggestion and after addressing it the PR is GTG.

pages/linux/networkctl.md Outdated Show resolved Hide resolved
pages.pl/linux/networkctl.md Outdated Show resolved Hide resolved
acuteenvy and others added 2 commits April 20, 2023 15:32
@acuteenvy @kbdharun
networkctl: add backticks around systemd-networkd
8867147 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@acuteenvy
networkctl: update Polish translation
4e27781
@acuteenvy
Copy link
Member Author

I applied your suggestion, but now that I think of it, systemd-networkd is not a command that should be run directly, it's a daemon started automatically by systemd. And according to this section of the style guide only commands should be surrounded with backticks. I'll leave it as is though if you think this is better.

@acuteenvy
Copy link
Member Author

So should I remove it or leave it as it is?

@kbdharun
Copy link
Member

So should I remove it or leave it as it is?

I guess it is fine

blueskyson
blueskyson approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine because no real-world environment labels an interface as "interface1".

@kbdharun kbdharun merged commit 197713d into tldr-pages:main Apr 23, 2023
@acuteenvy acuteenvy deleted the networkctl branch April 23, 2023 12:47
@pixelcmtd pixelcmtd mentioned this pull request May 13, 2023
Closed
@acuteenvy acuteenvy mentioned this pull request May 13, 2023
Open
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@blueskyson blueskyson blueskyson approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acuteenvy @kbdharun @blueskyson