Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just: update collision pages #10783

Merged
merged 2 commits into from
Oct 8, 2023
Merged

just: update collision pages #10783

merged 2 commits into from
Oct 8, 2023

Conversation

blueskyson
Copy link
Member

Refactoring based on #8786

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Oct 1, 2023
@tldr-bot

This comment was marked as resolved.

Sign in to view
@kbdharun kbdharun added the decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. label Oct 1, 2023
kbdharun
kbdharun approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

This indeed seems to be the ideal approach for handling name collisions, let's see how it pans out in the long run.

@kbdharun kbdharun requested a review from gutjuri October 8, 2023 10:21
gutjuri
gutjuri approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@kbdharun kbdharun merged commit 0ad2341 into tldr-pages:main Oct 8, 2023
4 checks passed
@blueskyson blueskyson deleted the refactor-just branch October 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

@pixelcmtd pixelcmtd Awaiting requested review from pixelcmtd

Assignees
No one assigned
Labels
decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blueskyson @tldr-bot @gutjuri @kbdharun