Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch_root, tailf, uuidparse, waitpid: add pages #12108

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

gutjuri
Copy link
Member

@gutjuri gutjuri commented Jan 22, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 22, 2024
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being part of util-linux, all commands are linux-exclusive, so we have to move them to linux/:

  • About tailf: FreeBSD, NetBSD, OpenBSD and osx don't (neither didn't) have such command.
  • switch_root, uuidparse and waitpid also don't have a manual page for FreeBSD, NetBSD, OpenBSD and osx.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contribution! I have some suggestions.

pages/linux/uuidparse.md Show resolved Hide resolved
pages/linux/uuidparse.md Show resolved Hide resolved
pages/linux/switch_root.md Show resolved Hide resolved
pages/linux/switch_root.md Show resolved Hide resolved
pages/linux/switch_root.md Outdated Show resolved Hide resolved
pages/linux/waitpid.md Show resolved Hide resolved
pages/linux/switch_root.md Show resolved Hide resolved
gutjuri and others added 3 commits January 22, 2024 18:45
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@kbdharun kbdharun merged commit 14bb4a9 into tldr-pages:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants