Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmesg: add page #1431

Merged
merged 4 commits into from
Jul 24, 2017
Merged

dmesg: add page #1431

merged 4 commits into from
Jul 24, 2017

Conversation

7373Lacym
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/dmesg.md:3: TLDR002 A single space should precede a sentence
pages/common/dmesg.md:3: TLDR004 Command descriptions should end in a period
pages/common/dmesg.md:5: TLDR002 A single space should precede a sentence
pages/common/dmesg.md:5: TLDR003 Descriptions should start with a capital letter
pages/common/dmesg.md:5: TLDR005 Example descriptions should end in a colon
pages/common/dmesg.md:9: TLDR003 Descriptions should start with a capital letter
pages/common/dmesg.md:9: TLDR005 Example descriptions should end in a colon
pages/common/dmesg.md:12: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/dmesg.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

agnivade
agnivade reviewed Jul 21, 2017
View reviewed changes
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only for unix-like operating systems, I would recommend you duplicate the page into individual folders of linux, osx and sunos.

agnivade
agnivade requested changes Jul 21, 2017
View reviewed changes
pages/common/dmesg.md Outdated
@@ -0,0 +1,11 @@
# dmesg

> Write the kernel messages in Linux and other Unix-like operating systems to standard output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we would be splitting the page into per-os level, we can remove the "Linux and other Unix-like operating systems".

So there, I suggest -

Display kernel messages to standard output.

pages/common/dmesg.md Outdated

> Write the kernel messages in Linux and other Unix-like operating systems to standard output.

- Show how much physical memory is available on this system:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should first put the example of the simplest command usage, which is just dmesg.

@agnivade agnivade added the new command Issues requesting creation of a new page. label Jul 21, 2017
@7373Lacym
Copy link
Author

Woo! Thanks for the feedback!

@agnivade
Copy link
Member

@sbrl - ping for review

sbrl
sbrl approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@agnivade I didn't see this one! I really need to keep a closer eye on the PRs page. You can tell that I forget about it and only keep an eye on my notifications..... :P

pages/linux/dmesg.md

- Show how much physical memory is available on this system:

`dmesg | grep -i memory`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really cool trick that I hadn't thought of. Awesome 😺

pages/linux/dmesg.md
@@ -0,0 +1,15 @@
# dmesg

> Write the kernel messages to standard output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a teensy bit awkward, but it's nothing to worry about - I can't think of anything better :P

@agnivade agnivade merged commit 8fcc087 into tldr-pages:master Jul 24, 2017
Nagiza pushed a commit to Nagiza/tldr that referenced this pull request Aug 4, 2017
@Nagiza
dmesg: add page (tldr-pages#1431)
a7df41a
@vitorhcl vitorhcl mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

@sbrl sbrl sbrl approved these changes

@120687 120687 120687 approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@7373Lacym @CLAassistant @tldr-bot @agnivade @sbrl @120687