-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnf5-group: add page #14958
dnf5-group: add page #14958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM with a few comments.
Co-authored-by: cyqsimon <28627918+cyqsimon@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
It's worth noting that dnf v5 only just became the default on Fedora 41. There are still many derivative distros out there (RHEL being the prime example) still on dnf v4, and due to their stability guarantees this will continue to be the case for a loooong time into the future. For those unaware, there are quite a number of breaking changes from v4 to v5. Two in particular that are pertinent to the CLI are:
In short, I do not think it is a great idea to state that these two are equivalent at this moment in time. At minimum, there should be a notice/warning about how this may not be the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained in my comment.
@cyqsimon So what would be appropriate according to you - just delete dnf-group.md alias page and leave rest as it is? @sebastiaanspeck also what are your thoughts on this? |
With a bit more in-depth consideration, it's not as straight-forward as I thought. Sorry about making it sound easier than it actually is. Here's a table to summarise the current situation. The strike-through ones are EOL:
On how Also related: #12316. The situation is slightly different but still very relevant. |
@cyqsimon I tested with dnf 4 also in docker ( Since |
That's reassuring to hear. Knowing this, I feel less worried about using an alias page.
In light of your verification, this would be redundant. Under the current situation, I think it's best we view the install name
What I suspect eventually will happen is Fedora 44 or something installs v5 as Apologies for the back and forth and all the hassle. Different install names is always a PITA to deal with. |
@cyqsimon Now I made |
Co-authored-by: cyqsimon <28627918+cyqsimon@users.noreply.github.com>
Co-authored-by: cyqsimon <28627918+cyqsimon@users.noreply.github.com>
@cyqsimon Changes you suggested are done, please merge now |
common
,linux
,osx
,windows
,sunos
,android
, etc.dnf5 version 5.2.7.0