-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkswap: add page #1984
mkswap: add page #1984
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Work!
Your description is also good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR !
Would you like to add -L
and -c
options too ? I believe they are useful and should be in the page.
pages/linux/mkswap.md
Outdated
|
||
- Setup a disk partition as swap area: | ||
|
||
`sudo mkswap {{partition}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us use a concrete example like /dev/sdb1
rather than partition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pages/linux/mkswap.md
Outdated
|
||
- Setup a file and use that file as swap space: | ||
|
||
`sudo mkswap {{filename}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filename => path/to/file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done !
pages/linux/mkswap.md
Outdated
|
||
`sudo mkswap {{partition}}` | ||
|
||
- Setup a file and use that file as swap space: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean to "Setup a file" ? Does it make sense to just say Use a given file as swap area:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Thanks for suggestion! I added those changes suggested by you. |
- Updated the description to use the word "partition" - Removed a preceding slash from file - Added a line on using swapon to make it more helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some very minor changes which makes the page a bit more consistent with the other pages. Hope that is fine by you.
Thanks for the contribution :)
Thanks for making corrections. I am glad to be part of tldr community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @shashank2806 - looks ok to me! 😺
Can't believe we didn't have this page before :P
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being edited.The page follows the contributing guidelines.