uptime: Fill out some more options #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
approved these changes
Jul 5, 2018
|
Yea, the platform thing is tricky. People try these commands from different systems. We need a comprehensive solution. The simplest way would be for the client to look into other folders and mention that the same page exists for a different platform. |
|
Indeed. Do we have a spec for 'official' clients or something? If we did, then we could include it in there. Alternatively there's the symbolic link solution - which has issues on Windows. It's that age old question in #1966 and #787 again.... |
|
We have #1065 which is not yet closed. It is more up @waldyrious' alley. |
owenvoke
approved these changes
Jul 8, 2018
|
Indeed, @agnivade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....I suspect that this belongs in
linux/too. Thoughts?The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.