-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMMUNITY-ROLES.md: format messages as quotes #2259
Conversation
This allows the template messages to retain the semantic line-breaking that improves the readability of their source code version control diffs, while at the same time they can be copy-pasted to issues without the line breaks (which is slightly problematic because github includes the line breaks even when rendering content as rich-text prose). Also, slightly reword a sentence in the "Past owners" section, to make it more general and cover more cases.
@@ -211,7 +203,7 @@ and are responsible for performing role changes in the community. | |||
### Past owners | |||
|
|||
The following people used to be owners in the tldr-pages organization, | |||
and have since moved on to other projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo at "otherwise" 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha thanks, let me fix it up real quick :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me! Thanks @waldyrious 😺
I had forgotten that this document existed. Thanks for the reminder too :P
IMO it's OK not to have these documents in mind at all times, but it's good to be generally aware that the sort of information they contain is described somewhere in the repo (and if not, it should), and be able to find it when the situation arises. |
@waldyrious - CLA issues again ? |
@agnivade I haven't (sadly) been merging TLDR-pages PRs recently to notice whether CLA-assistant has been failing consistently, but I did notice elsewhere that a lot of CI-like checks seem to be failing to report lately (not failing the check, but simply not reporting any status at all). I believe GitHub may have changed something recently about how such integrations work, but that's mostly speculation. Have you guys noticed anything strange recently with the checks in this repo or others you're active in? |
Ah, I think I know what might have happened -- since I was the one who set up the CLA, being removed from the org (#2257) probably removed the cla-assistant's connection to the repo. I should probably reach out to them to make sure re-setting it won't reset the list of signers... |
This allows the template messages to retain the semantic line-breaking
that improves the readability of their source code version control diffs,
while at the same time they can be copy-pasted to issues
without the line breaks (which is slightly problematic
because github includes the line breaks
even when rendering content as rich-text prose).
(Case in point: this very PR, which reuses the extended commit message.)
Also, slightly reword a sentence in the "Past owners" section,
to make it more general and cover more cases.