Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uname: mention lsb_release #302

Merged
merged 1 commit into from
Dec 7, 2015
Merged

uname: mention lsb_release #302

merged 1 commit into from
Dec 7, 2015

Conversation

waldyrious
Copy link
Member

No description provided.

@waldyrious
Copy link
Member Author

Not sure if this is the best way to do it; we could split the page and add the note only in linux/uname.md, but that seems overkill considering that the current options have been specifically selected to be the common denominator.

That said, the command does differ across systems, so we could adapt it to make use of that -- but I can't think, off the top of my head, of any change that would be beneficial for the tldr audience.

@waldyrious
Copy link
Member Author

Btw, I added the lsb_release.md page in #303

@waldyrious
Copy link
Member Author

@rprieto please review :)

@rprieto
Copy link
Contributor

rprieto commented Dec 6, 2015

Nice one 👍 Maybe in the conversation about a potential V2 format we can talk about a "related commands" section?

@waldyrious
Copy link
Member Author

@rprieto sure. I believe you've mentioned stuff for v2 in several threads now, so if you like, please open a new issue with the main changes to discuss off the top of your head, and then we can add a reference to this PR there as well. As for this change, and in the context of v1, I'll take your 👍 as a license to merge :)

waldyrious added a commit that referenced this pull request Dec 7, 2015
@waldyrious waldyrious merged commit 1fc78c6 into tldr-pages:master Dec 7, 2015
@waldyrious waldyrious deleted the patch-4 branch December 7, 2015 01:16
@waldyrious
Copy link
Member Author

Hm, maybe #190 could host the v2 discussion? If so we should probably tweak the title to make this clear.

@waldyrious
Copy link
Member Author

For future reference, this change broke Travis (which was set up after this PR was created), with the markdown lint error "MD028: Blank line inside blockquote". The fix was done in f3b5a63.

@waldyrious waldyrious added page edit Changes to an existing page(s). syntax Issues related to the content and markup of the pages. labels Sep 8, 2016
@waldyrious waldyrious changed the title mention lsb_release uname: mention lsb_release Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). syntax Issues related to the content and markup of the pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants