Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makepasswd: add page #3566

Merged
merged 3 commits into from
Nov 14, 2019
Merged

makepasswd: add page #3566

merged 3 commits into from
Nov 14, 2019

Conversation

Rudloff
Copy link
Collaborator

@Rudloff Rudloff commented Nov 13, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

I could not find any homepage for this command.

Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Left a minor comment for you to take a look at.
I'm not requesting changes, just commenting, because I think it can be merged as it is.
By the way, thank you for all your contributions for the last few days.

pages/common/makepasswd.md Outdated Show resolved Hide resolved
@mebeim mebeim added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 14, 2019
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
@mebeim mebeim merged commit f62c41c into tldr-pages:master Nov 14, 2019
@sbrl sbrl mentioned this pull request Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants