Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod: add Spanish translation #3705

Merged
merged 1 commit into from
Dec 31, 2019
Merged

chmod: add Spanish translation #3705

merged 1 commit into from
Dec 31, 2019

Conversation

ivanhercaz
Copy link
Collaborator

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@ivanhercaz ivanhercaz added the translation Issues requesting translating pages from English to other languages. label Dec 28, 2019
sbrl
sbrl approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're translating a batch of pages, feel free to open 1 big PR with 1 commit per page :D

@sbrl sbrl merged commit 2e0ae5c into tldr-pages:master Dec 31, 2019
@ivanhercaz
Copy link
Collaborator Author

If you're translating a batch of pages, feel free to open 1 big PR with 1 commit per page :D

I like to do that when I translate related pages, for example #3680, in which I translate the apt* commands. I am planning to do this for git related commands in a near-future. I really like to translate this commands.

But if you consider I should do it when I translate more than two in the same day, I will do it. The only issue is to predict that I am going to translate a batch, because sometimes I translate as I have time available in the day.

@ivanhercaz ivanhercaz deleted the es_chmod branch January 1, 2020 02:28
@sbrl
Copy link
Member

sbrl commented Jan 3, 2020

Ah, I see! No worries. Yeah, multiple unrelated translations are fine in 1 big PR. Multiple PRs are fine too if you find yourself doing an unplanned translation :P

You can always amend an existing PR if it hasn't been reviewed yet

@ivanhercaz
Copy link
Collaborator Author

Ah, I see! No worries. Yeah, multiple unrelated translations are fine in 1 big PR. Multiple PRs are fine too if you find yourself doing an unplanned translation :P

You can always amend an existing PR if it hasn't been reviewed yet

Nice! I will keep your comments in mind for the next time I work several commands at the same time. At this moment my biggest goal is to translate all the git commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@zlatanvasovic zlatanvasovic zlatanvasovic approved these changes

Assignees
No one assigned
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanhercaz @sbrl @zlatanvasovic