Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x0vncserver: add page #4478

Merged
merged 12 commits into from
Nov 27, 2020
Merged

x0vncserver: add page #4478

merged 12 commits into from
Nov 27, 2020

Conversation

funwaa
Copy link
Contributor

@funwaa funwaa commented Oct 4, 2020 •
edited
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

tldr-bot commented Oct 4, 2020

The build for this PR failed with the following error(s):

pages/common/screen.md:44: TLDR008 File should contain no trailing whitespace
pages/linux/x0vncserver.md:3: TLDR003 Descriptions should start with a capital letter
pages/linux/x0vncserver.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 4, 2020

The build for this PR failed with the following error(s):

pages/linux/x0vncserver.md:3: TLDR003 Descriptions should start with a capital letter
pages/linux/x0vncserver.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

navarroaxel
navarroaxel requested changes Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @funwaa, thanks for your submission! I left some comments.

If you think your examples are more important than the current ones in the screen.md please discuss about it. But we can't publish pages with more than 8 examples.

pages/common/screen.md Outdated

- Attach screen that is attached elsewhere (don't detach remote, will use resolution of remote's window):

`screen -x <name>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The md pages can't have more than 8 examples, we have 10 here.

@navarroaxel navarroaxel added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Oct 4, 2020
funwaa and others added 2 commits October 4, 2020 22:28
@funwaa @navarroaxel
Update pages/linux/x0vncserver.md
9952c15 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@funwaa @navarroaxel
Update pages/linux/x0vncserver.md
f23a8d3 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@funwaa
Copy link
Contributor Author

funwaa commented Oct 4, 2020

I personally think that the -dr option for screen should be more in a cheatsheet than just "screen" without any options at all, but that's just my opinion. Thanks for the heads up and I'm sorry, I wasn't aware of the 8 commands maximum!

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Oct 20, 2020
@navarroaxel navarroaxel removed the waiting Issues/PRs with Pending response by the author. label Oct 20, 2020
@github-actions
Copy link

github-actions bot commented Nov 5, 2020

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Nov 5, 2020
@navarroaxel navarroaxel added hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. and removed waiting Issues/PRs with Pending response by the author. labels Nov 5, 2020
@navarroaxel
Copy link
Collaborator

@funwaa Can you apply the changes to the screen.md page to continue with this PR?

navarroaxel
navarroaxel requested changes Nov 21, 2020
View reviewed changes
@navarroaxel navarroaxel changed the title x0vncserver: add page, screen: add commands x0vncserver: add page Nov 21, 2020
navarroaxel
navarroaxel requested changes Nov 21, 2020
View reviewed changes
navarroaxel
navarroaxel requested changes Nov 21, 2020
View reviewed changes
sbrl
sbrl approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @funwaa!

@sbrl sbrl merged commit 7813123 into tldr-pages:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@funwaa @CLAassistant @tldr-bot @navarroaxel @sbrl