Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy: add page #4511

Merged
merged 5 commits into from
Oct 7, 2020
Merged

scrcpy: add page #4511

merged 5 commits into from
Oct 7, 2020

Conversation

sahilister
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 6, 2020
navarroaxel
navarroaxel requested changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice page @sahilister.
I think you should add --stay-awake and --always-on-top examples.

pages/common/scrcpy.md Outdated Show resolved Hide resolved
pages/common/scrcpy.md Outdated Show resolved Hide resolved
pages/common/scrcpy.md Outdated Show resolved Hide resolved
pages/common/scrcpy.md Outdated Show resolved Hide resolved
sahilister and others added 4 commits October 7, 2020 11:19
@sahilister @navarroaxel
Update pages/common/scrcpy.md
98d5079 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@sahilister @navarroaxel
Update pages/common/scrcpy.md
4704ecf 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@sahilister @navarroaxel
Update pages/common/scrcpy.md
4278724 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@navarroaxel @sbrl
Apply suggestions from code review
e30e193 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
navarroaxel
navarroaxel approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sahilister for all your contributions!

@navarroaxel navarroaxel requested a review from sbrl October 7, 2020 11:29
sbrl
sbrl approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sahilister!

@sbrl sbrl merged commit 772cd91 into tldr-pages:master Oct 7, 2020
@sahilister sahilister deleted the scrcpy branch October 8, 2020 14:26
@sbrl sbrl mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahilister @navarroaxel @sbrl