Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aapt to ag: add Russian translation #4882

Merged
merged 17 commits into from
Nov 16, 2020
Merged

aapt to ag: add Russian translation #4882

merged 17 commits into from
Nov 16, 2020

Conversation

Rudokhvist
Copy link
Contributor

work in progress, will add more translations later.

@sbrl sbrl added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 28, 2020
@sbrl
Copy link
Member

sbrl commented Oct 28, 2020

Thanks, @Ryzhehvost! Just let us know when you're ready for us to review.

@navarroaxel navarroaxel added the translation Issues requesting translating pages from English to other languages. label Oct 28, 2020
@Rudokhvist Rudokhvist marked this pull request as ready for review November 1, 2020 20:00
@Rudokhvist
Copy link
Contributor Author

It seems that other contributors are not checking for WIP PRs (#4905), so I guess sending translations one-by-one makes more sense. Please review what was done so far, I may send more PRs later if I'll have time.

@Rudokhvist Rudokhvist changed the title [WIP] Russian translation of pages/common Russian translation of pages/common Nov 1, 2020
sbrl
sbrl approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't speak the language, but the syntax looks fine to me!

Thanks 🙂

I think to get other Russian-speaking contributors to review this PR, you'll need to @mention them specifically and ask them.

We generally prefer for translations if you're translating lots of pages for you to put them in a single PR, because it makes the maintenance workload easier to manage 🙂

@navarroaxel navarroaxel changed the title Russian translation of pages/common aapt to ag: add Russian translation Nov 9, 2020
@navarroaxel
Copy link
Collaborator

Hi @Ryzhehvost, thanks for your submissions. Some adb pages are already in the master branch, could you please resolve the conflicts?

And in the another hand:
If I check the pages in master:
Screenshot_20201109_073131
But I can't resolve the encoding of your pages:
Screenshot_20201109_073227

Could you change the encoding of your translations to UTF-8? Thanks!

@Rudokhvist
Copy link
Contributor Author

Oh damn, totally forgot about the encoding, sorry. Fixed it, and resolved conflicts, please review.

navarroaxel
navarroaxel reviewed Nov 10, 2020
View reviewed changes
Rudokhvist and others added 4 commits November 10, 2020 19:34
@Rudokhvist @navarroaxel
don't translate "activity" in examples, since it has no common term i…
49577ad 
…n russian

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Rudokhvist @navarroaxel
don't translate "activity" in description, since it has no common ter…
33ee7ee 
…m in russian

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Rudokhvist @navarroaxel
make descriptions consistent
e2c95bf 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Rudokhvist
fixes to adb-install
628dfd1
sbrl
sbrl approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't speak the language, but the syntax looks fine to me!

Thanks 🙂

@navarroaxel navarroaxel merged commit c2420e8 into tldr-pages:master Nov 16, 2020
@Rudokhvist Rudokhvist deleted the pages.ru branch November 16, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rudokhvist @sbrl @navarroaxel