Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amass, httprobe, sublist3r, theHarvester: add page #4912

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

wilco375
Copy link
Contributor

@wilco375 wilco375 commented Oct 31, 2020

This PR adds several pentesting tools to tldr.

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

Perhaps next time you could submit multiple pages in separate PRs? It makes reviewing easier :-)

Sorry about all the comments - with 4 new pages in this PR it makes the comments seem like more than they actually are.


- Save the output to an xml and html file:

`theHarvester --domain {{domain_name}} --source google --file {{output_file}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing token syntax? Also, perhaps this would be more consistent with other existing pages?

Suggested change
`theHarvester --domain {{domain_name}} --source google --file {{output_file}}`
`theHarvester --domain {{domain_name}} --source {{google}} --file {{path/to/output_file}}`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to write out the file format. You can provide a path, but for ex. when you provide outputdir/outputfile it will save a file called outputfile.xml and one called outputfile.html in the directory outputdir. So because you don't provide an extension it is kind of confusing.

@wilco375
Copy link
Contributor Author

wilco375 commented Nov 1, 2020

Thanks for the new page! I've left some comments below for you to review.

Perhaps next time you could submit multiple pages in separate PRs? It makes reviewing easier :-)

Sorry about all the comments - with 4 new pages in this PR it makes the comments seem like more than they actually are.

Thanks for the feedback! It is my first PR here, so next time I add more pages I will make sure to make separate PRs. I resolved most of your comments, a new review would be appreciated!

@owenvoke owenvoke added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 2, 2020
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wilco375!

@navarroaxel navarroaxel merged commit 2f2a114 into tldr-pages:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants