-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amass, httprobe, sublist3r, theHarvester: add page #4912
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page! I've left some comments below for you to review.
Perhaps next time you could submit multiple pages in separate PRs? It makes reviewing easier :-)
Sorry about all the comments - with 4 new pages in this PR it makes the comments seem like more than they actually are.
pages/common/theHarvester.md
Outdated
|
||
- Save the output to an xml and html file: | ||
|
||
`theHarvester --domain {{domain_name}} --source google --file {{output_file}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing token syntax? Also, perhaps this would be more consistent with other existing pages?
`theHarvester --domain {{domain_name}} --source google --file {{output_file}}` | |
`theHarvester --domain {{domain_name}} --source {{google}} --file {{path/to/output_file}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to write out the file format. You can provide a path, but for ex. when you provide outputdir/outputfile it will save a file called outputfile.xml and one called outputfile.html in the directory outputdir. So because you don't provide an extension it is kind of confusing.
Thanks for the feedback! It is my first PR here, so next time I add more pages I will make sure to make separate PRs. I resolved most of your comments, a new review would be appreciated! |
89c89db
to
cbf2146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @wilco375!
This PR adds several pentesting tools to tldr.
common/
,linux/
, etc.)