Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yetris: add page #4938

Merged
merged 5 commits into from
Nov 7, 2020
Merged

yetris: add page #4938

merged 5 commits into from
Nov 7, 2020

Conversation

sahilister
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

@@ -0,0 +1,40 @@
# yetris

> Tetris(r) game clone in terminal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the r in brackets is for here? Also, perhaps this will read better?

Suggested change
> Tetris(r) game clone in terminal.
> Clone of the game Tetris in the terminal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Tetris name and brand is trademarked by The Tetris Company.

I was/am not sure how that will work out here or legality of the name usage, so added "(r)" to it, which I saw in another Tetris clone's Debian manpage here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I was not aware of that!

sahilister and others added 2 commits November 5, 2020 20:14
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 6, 2020
@navarroaxel navarroaxel merged commit 1796834 into tldr-pages:master Nov 7, 2020
@bl-ue
Copy link
Contributor

bl-ue commented Jan 3, 2021

  • The page has 8 or fewer examples.

@sahilister it has 9!

@sahilister sahilister deleted the patch/yetris branch January 4, 2021 11:34
@sbrl
Copy link
Member

sbrl commented Jan 4, 2021

Erm oops! This page has 9 examples, but our limit is 8 examples per page. @sahilister, would you be able to open a pull request to correct this please?

@bl-ue
Copy link
Contributor

bl-ue commented Jan 4, 2021

@sbrl I've done this already @ #5079, in support of #5046.

@sbrl
Copy link
Member

sbrl commented Jan 4, 2021

Nice work, @bl-ue! I'm still working my way through my GH notifications (70 GH notifications? I thought it was Hacktoberfest for a moment 😅), so I haven't seen those yet.

@bl-ue
Copy link
Contributor

bl-ue commented Jan 4, 2021

Wow! That's a lot! Since you added me they've been coming a lot more, probably :)

@sbrl
Copy link
Member

sbrl commented Jan 7, 2021

Thanks so much, @bl-ue! Don't burn yourself out though 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants