Fix issue where common won't be required if os is detected #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad, I should have tested it more thoroughly... |
| @@ -14,7 +13,7 @@ function path(command, platform) { | |||
| } | |||
|
|
|||
| function getForPlatform(repository, command, platform, done) { | |||
| var pathCommon = path(command); | |||
| var pathCommon = path(command, "common"); | |||
| var pathPlatform = path(command, platform); | |||
There was a problem hiding this comment.
Do we expect platform to be set? If so would it just skip the OS lookup?
function path(command, platform) {
return (platform || osDirectories[os.platform()]) + '/' + command + '.md';
}There was a problem hiding this comment.
Yeah I added the optimist module so you can pass --os=osx as parameter to have the documentation for Mac OS X. This option is set as parameter to path for pathPlatform if it exists. It's more for debugging purpose though.
rprieto
added a commit
that referenced
this pull request
Jan 29, 2014
Fix issue where common won't be required if os is detected
waldyrious
added
the
architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erratum in last pull request #44
Must specify default platform "common" otherwise it will not be requested.