Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambo, lambo-new: add page #5139

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Conversation

owenvoke
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@owenvoke owenvoke added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 13, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jan 13, 2021

Is there a reason why you sometimes use = in flags but sometimes not?
Like this:

lambo new --path={{path/to/directory}} {{name}}

lambo new --auth {{name}}

@owenvoke
Copy link
Member Author

@bl-ue, because the ones without an equals sign don't have a value (they are a boolean value). Whereas the ones with = need a value.

@bl-ue
Copy link
Contributor

bl-ue commented Jan 13, 2021

Seems like an obvious one now. 😄 I wish I could laugh at that 5 times :D

Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be move to lambo-new.md and create a lambo.md for --help, edit-config, make-after, edit-after and the simplest lambo new subcommands.

@navarroaxel
Copy link
Collaborator

Hey @owenvoke, do you think this is not useful? #5139 (review)

@owenvoke
Copy link
Member Author

Apologies @navarroaxel, I missed that comment. I'm not entirely sure that this would be necessary. 🤔

@bl-ue
Copy link
Contributor

bl-ue commented Jan 18, 2021

I'm inclined to agree with @navarroaxel, because what about the other lambo subcommands like edit-config, make-after , and edit-after? Just because they may not be very useful/used often doesn't mean we shouldn't document them, you know.

@owenvoke
Copy link
Member Author

owenvoke commented Jan 18, 2021

Fair enough, I was just showing the most used commands that are the whole purpose of the tool. For reference make-after no longer exists as it's irrelevant, and there isn't a --help flag (it's displayed when no command or directory is specified). But I've added now split it into another page with the other commands.

@navarroaxel navarroaxel changed the title lambo: add page lambo, lambo-new: add page Jan 18, 2021
@navarroaxel navarroaxel merged commit d022d1f into tldr-pages:master Jan 18, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jan 18, 2021

Oh cool! I didn't notice lambo in addition to lambo-new 😄

Thank you @owenvoke!

@owenvoke owenvoke deleted the feature/lambo branch January 18, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants