Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmms, SafeEjectGPU: add pages #5163

Merged
merged 6 commits into from
Jan 22, 2021
Merged

lmms, SafeEjectGPU: add pages #5163

merged 6 commits into from
Jan 22, 2021

Conversation

0xf0xx0
Copy link
Contributor

@0xf0xx0 0xf0xx0 commented Jan 20, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 20, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jan 20, 2021

This PR seems to be a bit messed up. dot_clean was already added in #5144. Let me see if I can fix it.

@bl-ue
Copy link
Contributor

bl-ue commented Jan 20, 2021

It's cleaned up now.

I see the issue. @gingkathfox you opened a PR on your fork (GingkathFox#1) and something (I don't know what) got messed up. To prevent this in the future, run the following commands to update master, instead of opening a PR on your fork:

# only run this one if you don't have the upstream remote
git remote add upstream git@github.com:tldr-pages/tldr.git

# update master
git fetch upstream master
git rebase upstream/master
git push origin

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gingkathfox! I've left some comments below for you to review.

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jan 20, 2021

@bl-ue is this change good?

@bl-ue
Copy link
Contributor

bl-ue commented Jan 20, 2021

@gingkathfox some of the suggestions aren't applied yet. Please apply those first, then I'll review again :)

Otherwise, most certainly!

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jan 20, 2021

There we go, done :D

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jan 21, 2021

oh cool, thanks for another manpage site, ill be sure to check that also in future commits

@bl-ue bl-ue merged commit 12ed2e1 into tldr-pages:master Jan 22, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we've recently made a decision that all filenames should be lowercase if I recall correctly. Could someone open a PR to correct that here please?

@bl-ue
Copy link
Contributor

bl-ue commented Jan 22, 2021

@sbrl Funny! I forgot about that 😄

@gingkathfox will you please do the honors here? 🙏🏻

@sbrl sbrl mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants