Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtool: add page #5166

Merged
merged 5 commits into from
Jan 21, 2021
Merged

promtool: add page #5166

merged 5 commits into from
Jan 21, 2021

Conversation

GETandSELECT
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2021

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/promtool.md:3: TLDR004 Command descriptions should end in a period
pages/common/promtool.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/promtool.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/promtool.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/promtool.md:18: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@GETandSELECT
Copy link
Contributor Author

anon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Screenshot 2021-01-21 at 11 05 06

I don't wish to add a real email address to my git config, but I signed the CLA. Any idea how I can proceed?

@owenvoke
Copy link
Member

You can update it with your GitHub "noreply" email I think. If you go to your email settings it should show the noreply email near the bottom.

@owenvoke owenvoke changed the title promtool (application used for event monitoring and alerting): add page promtool: add page Jan 21, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jan 21, 2021

@GETandSELECT run this:

git config user.email "10598483+GETandSELECT@users.noreply.github.com"
git config user.name "Kargins"

git reset --soft HEAD~2
git commit -m "promtool: add page"

git push --force

It will—

  1. Set your email address for your fork of tldr-pages/tldr to your GitHub no-reply email address
  2. Set your name for your fork to be your GitHub display name
  3. Undo the last 2 commits (but not undo the contents)
  4. Re-commit using the new user info
  5. Push the commits, replacing the old ones with the new on.

Then, try the CLA again.

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 21, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @GETandSELECT and thank you for the new page! I've left some comments below for you to review.

GETandSELECT and others added 4 commits January 21, 2021 15:20
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel merged commit ca2b685 into tldr-pages:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants