-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numactl: add page #5167
numactl: add page #5167
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@navarroaxel I updated your suggestions to use the more portable syntax for running a command with arguments arguments (i.e. |
Great addition :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Looks like I missed one :)
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel Thanks for the help, next time I commit a page I will use your suggestions! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny grammar nit ;)
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for a sequence of reviews like that :) I'll try to condense it in to one big review next time.
It's coolio, I truly appreciate that you put so much effort into the correctness! Finally I will be able to tldr it xD I forget the option names all the time! And opening man all the time is annoying ;) |
I totally agree! ❤️ By the way, it's common to delete the branch after your PR is merged ;) |
common/
,linux/
, etc.)