Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numactl: add page #5167

Merged
merged 8 commits into from
Jan 22, 2021
Merged

numactl: add page #5167

merged 8 commits into from
Jan 22, 2021

Conversation

somefoo
Copy link
Contributor

@somefoo somefoo commented Jan 22, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/numactl.md:5: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/linux/numactl.md:9: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/linux/numactl.md:13: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2021

CLA assistant check
All committers have signed the CLA.

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 22, 2021
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@bl-ue
Copy link
Contributor

bl-ue commented Jan 22, 2021

@navarroaxel I updated your suggestions to use the more portable syntax for running a command with arguments arguments (i.e. numactl ... -- {{command}} {{command_arguments}) ;)

@somefoo
Copy link
Contributor Author

somefoo commented Jan 22, 2021

@navarroaxel I updated your suggestions to use the more portable syntax for running a command with arguments arguments (i.e. numactl ... -- {{command}} {{command_arguments}) ;)

Great addition :)

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Looks like I missed one :)

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@somefoo
Copy link
Contributor Author

somefoo commented Jan 22, 2021

@navarroaxel Thanks for the help, next time I commit a page I will use your suggestions! :)

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny grammar nit ;)

somefoo and others added 3 commits January 22, 2021 13:50
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for a sequence of reviews like that :) I'll try to condense it in to one big review next time.

@bl-ue bl-ue merged commit fab3ebc into tldr-pages:master Jan 22, 2021
@somefoo
Copy link
Contributor Author

somefoo commented Jan 22, 2021

LGTM! Sorry for a sequence of reviews like that :) I'll try to condense it in to one big review next time.

It's coolio, I truly appreciate that you put so much effort into the correctness! Finally I will be able to tldr it xD I forget the option names all the time! And opening man all the time is annoying ;)

@bl-ue
Copy link
Contributor

bl-ue commented Jan 22, 2021

I totally agree! ❤️

By the way, it's common to delete the branch after your PR is merged ;)

@somefoo somefoo deleted the add_numactl branch January 22, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants