scripts/pdf/render.py: fix typo #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When merging, please correct the commit message if necessary, I forgot to change it before I commited... |
|
I plan on reworking that script sometime. I'm a Python expert and that file could use some more cleanup 😉 |
bl-ue
changed the title
navarroaxel
approved these changes
Jan 30, 2021
sbrl
approved these changes
Jan 31, 2021
There was a problem hiding this comment.
Thanks!
Yeah, some rcleanup would be appreciated. I don't think was the one who wrote it (but if I did I don't remember), but my Python is rather rusty due to a preference for bracketed languages like JS and C# - so some assistance here would definitely be welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tdlr-pages-to-PDF→tldr-pages-to-pdf😄