Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native: add page #5208

Merged
merged 4 commits into from
Feb 2, 2021
Merged

react-native: add page #5208

merged 4 commits into from
Feb 2, 2021

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 31, 2021
@navarroaxel navarroaxel force-pushed the reactnative branch 2 times, most recently from 0d88454 to 4a4ae0a Compare January 31, 2021 03:39
bl-ue
bl-ue suggested changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a lot of react-related tools...😄

@navarroaxel @bl-ue
Apply suggestions from code review
ba56551 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel requested a review from bl-ue January 31, 2021 14:04
sbrl
sbrl requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

navarroaxel and others added 2 commits January 31, 2021 13:58
@navarroaxel @sbrl
Apply suggestions from code review
be8181d 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel
Update pages/common/react-native.md
892cf90
@navarroaxel navarroaxel requested a review from sbrl January 31, 2021 17:12
sbrl
sbrl approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @navarroaxel!

@navarroaxel navarroaxel merged commit 08b3bac into master Feb 2, 2021
@navarroaxel navarroaxel deleted the reactnative branch February 2, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@sbrl sbrl sbrl approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navarroaxel @owenvoke @sbrl @bl-ue