Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetifier: add page #5209

Merged
merged 3 commits into from
Feb 2, 2021
Merged

jetifier: add page #5209

merged 3 commits into from
Feb 2, 2021

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 31, 2021
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel requested a review from bl-ue January 31, 2021 14:02
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel requested a review from sbrl January 31, 2021 16:59
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @navarroaxel!

@sbrl sbrl merged commit 1f1b4d9 into master Feb 2, 2021
@sbrl sbrl deleted the jetifier branch February 2, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants