Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psalm: add page #5237

Merged
merged 2 commits into from
Feb 5, 2021
Merged

psalm: add page #5237

merged 2 commits into from
Feb 5, 2021

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Feb 5, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@owenvoke owenvoke added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 5, 2021
navarroaxel
navarroaxel requested changes Feb 5, 2021
View reviewed changes
@owenvoke @navarroaxel
psalm: apply changes from code review
2dbd3df 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@navarroaxel navarroaxel merged commit 981b7af into tldr-pages:master Feb 5, 2021
@owenvoke owenvoke deleted the feature/psalm branch February 5, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owenvoke @navarroaxel @bl-ue