Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch-chroot: add page #5248

Merged
merged 7 commits into from
Feb 25, 2021
Merged

arch-chroot: add page #5248

merged 7 commits into from
Feb 25, 2021

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Source code for check functionality: https://git.archlinux.org/arch-install-scripts.git/tree/arch-chroot.in

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 6, 2021
bl-ue
bl-ue suggested changes Feb 6, 2021
View reviewed changes
navarroaxel and others added 2 commits February 6, 2021 18:58
@navarroaxel @bl-ue
Apply suggestions from code review
6d24e50 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel
Remove sh example
5e559cd
bl-ue
bl-ue approved these changes Feb 6, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. It solves all my points and more beautifully in one commit! 😂

sbrl
sbrl reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

@navarroaxel @sbrl
Apply suggestions from code review
d2932fb 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel @waldyrious
Update pages/linux/arch-chroot.md
e7a6bbd 
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
@bl-ue bl-ue requested review from waldyrious and sbrl February 19, 2021 17:21
@navarroaxel @waldyrious
Apply suggestions from code review
953cc39 
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
navarroaxel
navarroaxel commented Feb 19, 2021
View reviewed changes
Copy link
Collaborator Author

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed specific example, and leave the generic previous example.

sbrl
sbrl approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @navarroaxel!

@navarroaxel navarroaxel merged commit 01dbbf6 into master Feb 25, 2021
@navarroaxel navarroaxel deleted the arch-chroot branch February 25, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@bl-ue bl-ue bl-ue approved these changes

@waldyrious waldyrious Awaiting requested review from waldyrious

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navarroaxel @waldyrious @sbrl @bl-ue