Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebase: fix typo in example #5259

Merged
merged 1 commit into from
Feb 11, 2021
Merged

firebase: fix typo in example #5259

merged 1 commit into from
Feb 11, 2021

Conversation

pbrennand-francis
Copy link
Contributor

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bl-ue bl-ue added the page edit Changes to an existing page(s). label Feb 11, 2021
@bl-ue bl-ue requested review from sbrl and navarroaxel February 11, 2021 14:44
@bl-ue bl-ue changed the title firebase: fixing typo in projects:list firebase: fix typo in example Feb 11, 2021
bl-ue
bl-ue approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch @pbrennand-francis! 😉

@navarroaxel navarroaxel merged commit 69b3a19 into tldr-pages:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@bl-ue bl-ue bl-ue approved these changes

@sbrl sbrl Awaiting requested review from sbrl

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbrennand-francis @CLAassistant @navarroaxel @bl-ue