Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add link to tldr.finzzz.net #5289

Merged
merged 2 commits into from
Feb 25, 2021
Merged

README: add link to tldr.finzzz.net #5289

merged 2 commits into from
Feb 25, 2021

Conversation

finzzz
Copy link

@finzzz finzzz commented Feb 20, 2021

  • The PR title conforms to the recommended templates

Fixes: #5287

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2021

CLA assistant check
All committers have signed the CLA.

@bl-ue bl-ue self-requested a review February 20, 2021 14:09
@bl-ue
Copy link
Contributor

bl-ue commented Feb 20, 2021

I'm sorry @finzzz I meant issue description, not title. I update it.

@bl-ue bl-ue changed the title Fixes: #5287 README: add link to tldr.finzzz.net Feb 20, 2021
@bl-ue bl-ue added clients Issues pertaining to a particular client or the clients as whole. community Issues/PRs dealing with role changes and community organization. labels Feb 20, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Feb 20, 2021

@finzzz the CLA isn't working because the email address that you used for the commit (git@finzzz.net) isn't added to your GitHub account. To fix this, you can either:

  1. Change the email you used for the commit† to one of the emails attached to your GitHub account,

  2. Or, preferably (and much easier), add the email you used for this commit (git@finzzz.net) to your GitHub account.

†To change the email address of the last commit, run this command:

git commit --amend --author="Vincent Carlos <email addres that you want to use instead>"

@finzzz
Copy link
Author

finzzz commented Feb 20, 2021

okay, can you try again?

@bl-ue
Copy link
Contributor

bl-ue commented Feb 20, 2021

Okay, the commit looks good. Now just sign the CLA.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @finzzz!

The slashes are really just a neatness thing. We can either resolve that here, or open another quick PR to fix it. Either way, I don't think it's blocking this PR from being merged.

Suggestions applied by @bl-ue for expediency

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@bl-ue bl-ue merged commit aa47015 into tldr-pages:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Issues pertaining to a particular client or the clients as whole. community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New web client
5 participants