-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plattformio-home: add alias page #5407
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Hmm...I haven't thought about alias pages for the parent commands. 🤔 The only reason I'd advise against it would be because it would create a lot of pages (however many aliases of the root command × however many subcommands 😬). But I think that probably doesn't matter. But I'd like @sbrl to see, because she's supporting this idea :) |
@bl-ue sure, I'll just do the original subcomands for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But let's keep this one anyway.
Hrm, this is an interesting case. I'm on the fence about this actually, in that I'm somewhat concerned about the large number of aliases as @bl-ue mentions. I would guess that you'd try |
@sbrl I also think that would be too much. Just having the |
I'm closing this PR, but we can always reopen if there's more to discuss. |
platformio-home
is an alias ofpio-home
(#5406)