Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yapf: add page and Dutch translation #5435

Merged
merged 12 commits into from
Mar 13, 2021
Merged

Conversation

Waples
Copy link
Member

@Waples Waples commented Mar 13, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2021

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/yapf.md:3: TLDR004 Command descriptions should end in a period
pages/common/yapf.md:5: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:9: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:13: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/yapf.md:3: TLDR004 Command descriptions should end in a period
pages/common/yapf.md:4: TLDR004 Command descriptions should end in a period
pages/common/yapf.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@bl-ue bl-ue added new command Issues requesting creation of a new page. translation Translate pages from one language to another. labels Mar 13, 2021
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/yapf.md:3: TLDR004 Command descriptions should end in a period
pages/common/yapf.md:4: TLDR004 Command descriptions should end in a period
pages/common/yapf.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/yapf.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Waples, please use periods at the end of page descriptions and colons at the end of example descriptions.

pages.nl/common/yapf.md Outdated Show resolved Hide resolved
pages.nl/common/yapf.md Outdated Show resolved Hide resolved
pages.nl/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages.nl/common/yapf.md Outdated Show resolved Hide resolved
@bl-ue bl-ue changed the title yapf: add initial pages for yapf in dutch and english yapf: add page and Dutch translation Mar 13, 2021
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/yapf.md:4: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@Waples
Copy link
Member Author

Waples commented Mar 13, 2021

Pushed the changes you requested.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for new the page (and translation) @Waples! I've left some comments below for you to review. You may need to update the Dutch translation to match the modification made to the English 😉

pages/common/yapf.md Outdated Show resolved Hide resolved
pages.nl/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages.nl/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
Waples and others added 5 commits March 13, 2021 16:08
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples
Copy link
Member Author

Waples commented Mar 13, 2021

Applied your suggestions, gonna double check the dutch translation in a moment.

pages/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
pages/common/yapf.md Outdated Show resolved Hide resolved
Waples and others added 2 commits March 13, 2021 16:21
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@Waples
Copy link
Member Author

Waples commented Mar 13, 2021

Fixed it my dude.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Waples for the new page! I like that there's already a translation for it, too :)

Looks good. 👍🏻

@Waples
Copy link
Member Author

Waples commented Mar 13, 2021

ill probably add more in the future =D

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me - thanks, @Waples!

pages/common/yapf.md Outdated Show resolved Hide resolved
@sbrl sbrl merged commit 79ebb31 into tldr-pages:master Mar 13, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Apr 13, 2021

Hey there @Waples do you mind checking https://gitter.im/bl-ue?

@Waples
Copy link
Member Author

Waples commented Apr 14, 2021

Hey there @Waples do you mind checking https://gitter.im/bl-ue?
Yes sir =D

@Waples Waples deleted the yapf-en-nl branch April 14, 2021 14:27
@bl-ue bl-ue mentioned this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants