-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yapf: add page and Dutch translation #5435
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Waples, please use periods at the end of page descriptions and colons at the end of example descriptions.
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Pushed the changes you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for new the page (and translation) @Waples! I've left some comments below for you to review. You may need to update the Dutch translation to match the modification made to the English 😉
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Applied your suggestions, gonna double check the dutch translation in a moment. |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Fixed it my dude. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Waples for the new page! I like that there's already a translation for it, too :)
Looks good. 👍🏻
ill probably add more in the future =D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me - thanks, @Waples!
Hey there @Waples do you mind checking https://gitter.im/bl-ue? |
|
common/
,linux/
, etc.)