Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basename: update French translation #5501

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Conversation

patricedenis
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Please consider merging this pull request.
Also, can someone explain me how can I add the "translation" label to the pull request in order to sort it better?

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages.fr/common/basename.md:9 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- N'afficher que le nom du der..."]

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the translation Translate pages from one language to another. label Mar 24, 2021
@navarroaxel
Copy link
Collaborator

Hey @patricedenis you can translate several pages in 1 PR, and also please add the more info link to the main (English) page too. Thanks!

@patricedenis
Copy link
Collaborator Author

patricedenis commented Mar 24, 2021

ok I did not see how to do that but I think I just found.
You commit several commits into one branch and after that you can do a PR for the whole?
Also, is it possible to create a branch with a specific name directly into the Web GUI?

@patricedenis
Copy link
Collaborator Author

Ok I did try to merge all my commits into just one PR to update basename

@bl-ue
Copy link
Contributor

bl-ue commented Mar 24, 2021

@patricedenis

You commit several commits into one branch and after that you can do a PR for the whole?

Yes, that's exactly right 👍🏻

Also, is it possible to create a branch with a specific name directly into the Web GUI?

Yes, I believe you can, when you create the PR.

@patricedenis
Copy link
Collaborator Author

@bl-ue and @navarroaxel thank you both for your feedbacks

@bl-ue
Copy link
Contributor

bl-ue commented Mar 26, 2021

Also, can someone explain me how can I add the "translation" label to the pull request in order to sort it better?

@patricedenis only repository collaborators and organization members can add/remove issue/PR labels. Seeing "translation" in the PR title thought makes it very easy to identify it as a translation and so it's not much work to label, but thank you for the offer!

I'm not sure if GitHub supports PR templates like it does issue templates. If it did, we could create PR templates for translations, page edits, new commands, etc., and have labels automatically added when a user creates a PR. With issue templates, you can configure which labels should automatically be applied when a user opened an issue 🤔

I'll merge this now, seems like it slipped out of my notice.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sort of cleanup PRs are priceless. IMO, they take skill and a real desire to improve the project. Thank you @patricedenis!

@bl-ue bl-ue merged commit 804ae28 into tldr-pages:master Mar 26, 2021
@patricedenis
Copy link
Collaborator Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants