Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pio-org: add page #5525

Merged
merged 5 commits into from
Mar 30, 2021
Merged

pio-org: add page #5525

merged 5 commits into from
Mar 30, 2021

Conversation

marchersimon
Copy link
Collaborator

Part of #5517

@marchersimon marchersimon added the new command Issues requesting creation of a new page. label Mar 28, 2021
@marchersimon marchersimon mentioned this pull request Mar 28, 2021
23 tasks
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments. Also @marchersimon: I forgot to discuss this in the other PRs (now merged, so we'll need to open a new PR to correct those), but will you please change the variable names to the longer formats in this and your other open PIO PRs, i.e.

  • orgnameorganization_name
  • new_orgnamenew_organization_name
  • new_displaynamenew_display_name
  • etc.

pages/common/pio-org.md Outdated Show resolved Hide resolved
pages/common/pio-org.md Outdated Show resolved Hide resolved
marchersimon and others added 2 commits March 28, 2021 22:47
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@marchersimon
Copy link
Collaborator Author

@bl-ue those terms don't occur in the already merged PRs, so there's no need for a new one.

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel merged commit da099ba into tldr-pages:master Mar 30, 2021
@marchersimon marchersimon deleted the pio-org branch March 30, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants